[PATCH] D88049: [docs] Update ExtendingLLVM.rst
Antonio via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Mon Sep 21 14:54:20 PDT 2020
antonio-cortes-perez created this revision.
Herald added a project: LLVM.
Herald added a subscriber: llvm-commits.
antonio-cortes-perez requested review of this revision.
Updated file paths and function signatures in section
"Adding a new type".
Repository:
rG LLVM Github Monorepo
https://reviews.llvm.org/D88049
Files:
llvm/docs/ExtendingLLVM.rst
Index: llvm/docs/ExtendingLLVM.rst
===================================================================
--- llvm/docs/ExtendingLLVM.rst
+++ llvm/docs/ExtendingLLVM.rst
@@ -246,11 +246,11 @@
add enum for the new type; add static ``Type*`` for this type
-#. ``llvm/lib/IR/Type.cpp`` and ``llvm/lib/IR/ValueTypes.cpp``:
+#. ``llvm/lib/IR/Type.cpp`` and ``llvm/lib/CodeGen/ValueTypes.cpp``:
add mapping from ``TypeID`` => ``Type*``; initialize the static ``Type*``
-#. ``llvm/llvm/llvm-c/Core.cpp``:
+#. ``llvm/include/llvm-c/Core.h`` and ``llvm/lib/IR/Core.cpp``:
add enum ``LLVMTypeKind`` and modify
``LLVMTypeKind LLVMGetTypeKind(LLVMTypeRef Ty)`` for the new type
@@ -265,12 +265,11 @@
#. ``llvm/lib/Bitcode/Writer/BitcodeWriter.cpp``:
- modify ``static void WriteTypeTable(const ValueEnumerator &VE,
- BitstreamWriter &Stream)`` to serialize your type
+ modify ``void ModuleBitcodeWriter::writeTypeTable()`` to serialize your type
#. ``llvm/lib/Bitcode/Reader/BitcodeReader.cpp``:
- modify ``bool BitcodeReader::ParseTypeType()`` to read your data type
+ modify ``Error BitcodeReader::parseTypeTableBody()`` to read your data type
#. ``include/llvm/Bitcode/LLVMBitCodes.h``:
@@ -288,11 +287,11 @@
add new class to represent new class in the hierarchy; add forward
declaration to the TypeMap value type
-#. ``llvm/lib/IR/Type.cpp`` and ``llvm/lib/IR/ValueTypes.cpp``:
+#. ``llvm/lib/IR/Type.cpp`` and ``llvm/lib/CodeGen/ValueTypes.cpp``:
add support for derived type, notably `enum TypeID` and `is`, `get` methods.
-#. ``llvm/llvm/llvm-c/Core.cpp``:
+#. ``llvm/include/llvm-c/Core.h`` and ``llvm/lib/IR/Core.cpp``:
add enum ``LLVMTypeKind`` and modify
`LLVMTypeKind LLVMGetTypeKind(LLVMTypeRef Ty)` for the new type
@@ -304,12 +303,11 @@
#. ``llvm/lib/Bitcode/Writer/BitcodeWriter.cpp``:
- modify ``static void WriteTypeTable(const ValueEnumerator &VE,
- BitstreamWriter &Stream)`` to serialize your type
+ modify ``void ModuleBitcodeWriter::writeTypeTable()`` to serialize your type
#. ``llvm/lib/Bitcode/Reader/BitcodeReader.cpp``:
- modify ``bool BitcodeReader::ParseTypeType()`` to read your data type
+ modify ``Error BitcodeReader::parseTypeTableBody()`` to read your data type
#. ``include/llvm/Bitcode/LLVMBitCodes.h``:
-------------- next part --------------
A non-text attachment was scrubbed...
Name: D88049.293260.patch
Type: text/x-patch
Size: 2331 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20200921/6bf9b63e/attachment.bin>
More information about the llvm-commits
mailing list