[PATCH] D87721: [PowerPC][PCRelative] Thread Local Storage Support for Local Dynamic

[Stefan Pintilie via Phabricator via llvm-commits]

stefanp accepted this revision.
stefanp added a comment.
This revision is now accepted and ready to land.

You can probably merge `pcrel-tls-local-dynamic-address-load-reloc.s` and `pcrel-tls-local-dynamic-value-load-reloc.s`. 
They are short test cases and they are testing almost exactly the same thing.

I think you can address these nits on review. LGTM.



================
Comment at: llvm/test/CodeGen/PowerPC/pcrel-tls-local-dynamic.ll:5
+; RUN:   -ppc-asm-full-reg-names --relocation-model=pic -enable-ppc-pcrel-tls --filetype=obj < %s | \
+; RUN:   llvm-objdump --mcpu=pwr10 -dr - | FileCheck %s --check-prefix=CHECK-O
+
----------------
Consider using `--no-show-raw-insn` for the objdumps.
We are not checking the instruction encoding.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D87721/new/

https://reviews.llvm.org/D87721