[PATCH] D88036: Version 0.5 of the "TableGen Backend Developer's Guide"

[Paul C. Anagnostopoulos via Phabricator via llvm-commits]

Paul-C-Anagnostopoulos added inline comments.


================
Comment at: llvm/docs/TableGen/BackEnds.rst:17
+
+TableGen is used by both LLVM and Clang with very different goals. LLVM uses
+it as a way to automate the generation of massive amounts of information
----------------
lattner wrote:
> Might mention MLIR as well, which uses TableGen extensively as the basis for its ODS system:
> https://mlir.llvm.org/docs/OpDefinitions/
I will add a mention of MLIR.


================
Comment at: llvm/lib/TableGen/TableGenBackendSkeleton.cpp:1
+//===- [SkeletonEmitter.cpp - Skeleton TableGen backend]     -*- C++ -*-===//
+//
----------------
lattner wrote:
> I think that adding an example backend is a good idea, but please make it valid C++ code that follows the coding standard etc.
Hmm. Then I have to replace all the metasyntactic items with syntactically-valid items. The idea was to have the compilation fail if someone forgot to replace one of the meta items with their real item. How about if I use real items but uppercase them all so they stand out? I would note that convention in the initial comment.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D88036/new/

https://reviews.llvm.org/D88036