[PATCH] D87420: scudo: Introduce a new mechanism to let Scudo access a platform-specific TLS slot

Kostya Kortchinsky via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Sep 21 12:52:43 PDT 2020


cryptoad added inline comments.


================
Comment at: compiler-rt/lib/scudo/standalone/tsd_shared.h:192
 
   pthread_key_t PThreadKey;
   atomic_u32 CurrentIndex;
----------------
russell.gallop wrote:
> Is this still needed? The key is just created and deleted with nothing set or get. Apologies if I've missed something.
That's a good point, it's no longer used, and we don't use the key destructor for the shared model.
I'll remove it in another CL.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D87420/new/

https://reviews.llvm.org/D87420



More information about the llvm-commits mailing list