[PATCH] D88028: [AMDGPU] More codegen patterns for v2i16/v2f16 build_vector

[Jay Foad via Phabricator via llvm-commits]

foad added a comment.

In D88028#2285683 <https://reviews.llvm.org/D88028#2285683>, @rampitec wrote:

> Can this appear later in the codegen?

I doubt it, and I haven't found any cases where that happens.

> It also does not cover global isel, so part in the operand folding probably needs to remain in addition to patterns.

The whole point of instruction selection is to select the best instructions. I really don't think any instruction selector should rely on having this kind of folding run later.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D88028/new/

https://reviews.llvm.org/D88028