[PATCH] D88035: [AArch64] Teach analyzeBranch to remove branch equivelent to fallthrough

[Philip Reames via Phabricator via llvm-commits]

reames created this revision.
reames added reviewers: resistor, efriedma.
Herald added subscribers: dantrushin, danielkiss, bollu, hiraditya, kristof.beyls, mcrosier.
Herald added a project: LLVM.
reames requested review of this revision.

The motivation here is that MachineBlockPlacement relies on analyzeBranch to remove branches to fallthrough blocks when the branch is not fully analyzeable.  With the introduction of the FAULTING_OP psuedo for implicit null checking (see D87861 <https://reviews.llvm.org/D87861>), this case becomes important.  Note that it's hard to otherwise exercise this path as BranchFolding handle's any fully analyzeable branch sequence without using this interface.

p.s. For anyone who saw my comment in the original review, what I thought was an issue in BranchFolding originally turned out to simply be a bug in my patch.  (Now fixed.)


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D88035

Files:
  llvm/lib/Target/AArch64/AArch64InstrInfo.cpp
  llvm/test/CodeGen/AArch64/implicit-null-check.ll

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D88035.293212.patch
Type: text/x-patch
Size: 4648 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20200921/ed590bac/attachment.bin>