[PATCH] D87798: [NewPM][CGSCC] Handle newly added functions in updateCGAndAnalysisManagerForPass

[Arthur Eubanks via Phabricator via llvm-commits]

aeubanks marked an inline comment as done.
aeubanks added inline comments.


================
Comment at: llvm/lib/Analysis/CGSCCPassManager.cpp:519
+  for (Node *NewNode : NewNodes) {
+    G.initNode(*NewNode, *C);
+  }
----------------
asbirlea wrote:
> I'm not clear how adding this call impacts the Inliner.
It shouldn't affect the inliner. For a given inline, the inliner will remove an edge, and potentially add new call/ref edges (corresponding to any call/ref edges in the inlined function). All of those will already have nodes since they were further down the call graph.

This would only affect completely new functions being created (or potentially new calls to functions up the call graph, which would be a bug, not sure if that's caught by asserts or not).


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D87798/new/

https://reviews.llvm.org/D87798