[PATCH] D88023: [LLD][ELF][test] Fix CHECKs in map-file test

Edd Dawson via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Sep 21 07:38:18 PDT 2020


edd created this revision.
edd added reviewers: grimar, MaskRay, psmith, ruiu.
Herald added subscribers: llvm-commits, emaste.
Herald added a reviewer: espindola.
Herald added a project: LLVM.
edd requested review of this revision.

A repeated typo in lld/test/ELF/map-file.s prevented a number of checks from being executed.

`CHECk-NEXT -> CHECK-NEXT`
`    ^             ^`

After correcting the typo, a small adjustment was needed to match the size of the synthetic .comment section (which always contains "LLD 1.0" in the test environment).


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D88023

Files:
  lld/test/ELF/map-file.s


Index: lld/test/ELF/map-file.s
===================================================================
--- lld/test/ELF/map-file.s
+++ lld/test/ELF/map-file.s
@@ -79,22 +79,22 @@
 # CHECK-NEXT:          202430           202430      100     8 .dynamic
 # CHECK-NEXT:          202430           202430      100     8         <internal>:(.dynamic)
 # CHECK-NEXT:          203530           203530       28     8 .got.plt
-# CHECk-NEXT:          203530           203530       28     8         <internal>:(.got.plt)
-# CHECk-NEXT:          203560           203560       10    16 .bss
-# CHECk-NEXT:          203560           203560        4    16         {{.*}}{{/|\\}}map-file.s.tmp1.o:(COMMON)
-# CHECk-NEXT:          203560           203560        4     1                 common
-# CHECk-NEXT:          203564           203564        4     1         <internal>:(.bss)
-# CHECk-NEXT:          203564           203564        4     1                 sharedFoo
-# CHECk-NEXT:          203568           203568        8     1         <internal>:(.bss)
-# CHECk-NEXT:          203568           203568        8     1                 sharedBar
-# CHECk-NEXT:               0                0       48     1 .comment
-# CHECk-NEXT:               0                0       48     1         <internal>:(.comment)
-# CHECk-NEXT:               0                0      198     8 .symtab
-# CHECk-NEXT:               0                0      198     8         <internal>:(.symtab)
-# CHECk-NEXT:               0                0       84     1 .shstrtab
-# CHECk-NEXT:               0                0       84     1         <internal>:(.shstrtab)
-# CHECk-NEXT:               0                0       6d     1 .strtab
-# CHECk-NEXT:               0                0       6d     1         <internal>:(.strtab)
+# CHECK-NEXT:          203530           203530       28     8         <internal>:(.got.plt)
+# CHECK-NEXT:          203560           203560       10    16 .bss
+# CHECK-NEXT:          203560           203560        4    16         {{.*}}{{/|\\}}map-file.s.tmp1.o:(COMMON)
+# CHECK-NEXT:          203560           203560        4     1                 common
+# CHECK-NEXT:          203564           203564        4     1         <internal>:(.bss)
+# CHECK-NEXT:          203564           203564        4     1                 sharedFoo
+# CHECK-NEXT:          203568           203568        8     1         <internal>:(.bss)
+# CHECK-NEXT:          203568           203568        8     1                 sharedBar
+# CHECK-NEXT:               0                0        8     1 .comment
+# CHECK-NEXT:               0                0        8     1         <internal>:(.comment)
+# CHECK-NEXT:               0                0      198     8 .symtab
+# CHECK-NEXT:               0                0      198     8         <internal>:(.symtab)
+# CHECK-NEXT:               0                0       84     1 .shstrtab
+# CHECK-NEXT:               0                0       84     1         <internal>:(.shstrtab)
+# CHECK-NEXT:               0                0       6d     1 .strtab
+# CHECK-NEXT:               0                0       6d     1         <internal>:(.strtab)
 
 # RUN: not ld.lld %t1.o %t2.o %t3.o %t4.a -o /dev/null -Map=/ 2>&1 \
 # RUN:  | FileCheck --check-prefix=FAIL %s


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D88023.293166.patch
Type: text/x-patch
Size: 3274 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20200921/b1ba87a3/attachment.bin>


More information about the llvm-commits mailing list