[PATCH] D88011: [ARM] Add patterns for vmulh

[Dave Green via Phabricator via llvm-commits]

dmgreen added inline comments.


================
Comment at: llvm/lib/Target/ARM/ARMISelLowering.cpp:762
 
-    setOperationAction(ISD::MULHS, VT, Expand);
     setOperationAction(ISD::SMUL_LOHI, VT, Expand);
----------------
samparker wrote:
> So this doesn't break for non-vector targets then? Do they get expanded automatically because no vector types are supported?
Do you mean like a cortex-m33? Where there is no MVE or NEON? I admit I didn't even consider that - but I think you are right. Everything will end up being scalarized anyway, and i32 mulhs/mulhu are handled appropriately.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D88011/new/

https://reviews.llvm.org/D88011