[PATCH] D87616: [ARM][LowOverheadLoops] Combine a VCMP and VPST into a VPT
Sam Tebbs via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Mon Sep 21 07:27:22 PDT 2020
samtebbs marked an inline comment as done.
samtebbs added inline comments.
================
Comment at: llvm/lib/Target/ARM/ARMLowOverheadLoops.cpp:1326
+ // Register one
+ MIB.add(VCMP->getOperand(1));
+ // Register two
----------------
dmgreen wrote:
> The VPT block pass has some very similar code. Do we need to check that Operand 1 and Operand 2 have not been modified between the VCMP and where we are materializing the VPT to?
That is a good spot. I'll submit a check for this in a follow-up.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D87616/new/
https://reviews.llvm.org/D87616
More information about the llvm-commits
mailing list