[PATCH] D87899: [llvm-readobj/elf] - Stop reporting invalid extended indexes in warnings for unnamed section symbols.

Mon Sep 21 04:11:49 PDT 2020

grimar added a comment.

In D87899#2284675 <https://reviews.llvm.org/D87899#2284675>, @jhenderson wrote:

> In D87899#2284145 <https://reviews.llvm.org/D87899#2284145>, @MaskRay wrote:
>
>> All the passing of `FirstSym` is for `&Sym - &FirstSym` in ELF.h getExtendedSymbolTableIndex. If we only care about the index, passing around the index rather than the first symbol probably makes more sense?
>
> +1 - this makes sense to me too. Everything else looks good.

I've prepared an independent NFCI patch for `getExtendedSymbolTableIndex` and other API: D88016 <https://reviews.llvm.org/D88016>

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D87899/new/

https://reviews.llvm.org/D87899