[PATCH] D87357: [SelectionDAG][DebugInfo] Use entry-values to recover parameters values

[Djordje Todorovic via Phabricator via llvm-commits]

djtodoro added a comment.

@aprantl thanks for your comments.



================
Comment at: llvm/lib/CodeGen/SelectionDAG/InstrEmitter.cpp:710
 
   if (SD->isInvalidated()) {
+    Register Reg = 0;
----------------
aprantl wrote:
> Can you add a comment that explains what's happening here?
Sure.


================
Comment at: llvm/lib/CodeGen/SelectionDAG/InstrEmitter.cpp:718
+    if (EntryValue && ValueMap) {
+      auto VMI = ValueMap->find(EntryValue);
+      if (VMI != ValueMap->end()) {
----------------
aprantl wrote:
> Would ValueMap.lookup() work here?
It'd work, thanks.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D87357/new/

https://reviews.llvm.org/D87357