[PATCH] D86905: Flush bitcode incrementally for LTO output

[David Stuttard via Phabricator via llvm-commits]

dstuttard added inline comments.


================
Comment at: llvm/include/llvm/Bitstream/BitstreamWriter.h:158
+    // Copy data to update into Bytes from the file FS and the buffer Out.
+    char Bytes[8];
+    size_t BytesNum = StartBit ? 8 : 4;
----------------
stephan.yichao.zhao wrote:
> stephan.yichao.zhao wrote:
> > dstuttard wrote:
> > > Microsoft Visual C++ is warning that this needs to be char Bytes[9]
> > > 
> > > Can this be updated (at least to silence the warning, we use warnings as errors in our builds)?
> > Yes. I will be fixing it.
> > What is the name of this warning from Visual C++? 
> https://github.com/llvm/llvm-project/commit/cab6f5b2ab814a4be3fd71aacdbe10298f512833
Sorry - should have included that in the original report. It's warning C6386:

\llvm-project\llvm\include\llvm\Bitstream\BitstreamWriter.h(177) : warning C6386: Buffer overrun while writing to 'Bytes':  the writable size
 is '8' bytes, but '9' bytes might be written.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D86905/new/

https://reviews.llvm.org/D86905