[PATCH] D88001: [flang][msvc] Add explicit function template argument to applyLamda. NFC.

Michael Kruse via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Sep 21 00:06:02 PDT 2020


Meinersbur created this revision.
Meinersbur added reviewers: isuruf, DavidTruby, sscalpone, klausler, tskeith.
Herald added a project: LLVM.
Herald added a subscriber: llvm-commits.
Meinersbur requested review of this revision.

Like in D87961 <https://reviews.llvm.org/D87961>, msvc has difficulties deducing the template argument. The error message is:

  expr-parsers.cpp(383): error C2672: 'applyLambda': no matching overloaded function found

Explicitly pass the first template argument to help it.

This patch is part of the series to make flang compilable with MS Visual Studio http://lists.llvm.org/pipermail/flang-dev/2020-July/000448.html.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D88001

Files:
  flang/lib/Parser/expr-parsers.cpp


Index: flang/lib/Parser/expr-parsers.cpp
===================================================================
--- flang/lib/Parser/expr-parsers.cpp
+++ flang/lib/Parser/expr-parsers.cpp
@@ -379,8 +379,8 @@
           return Expr{Expr::DefinedBinary(
               std::move(op), std::move(result).value(), std::move(right))};
         }};
-    auto more{
-        attempt(sourced(applyLambda(defBinOp, definedOpName, level5Expr)))};
+    auto more{attempt(
+        sourced(applyLambda<Expr>(defBinOp, definedOpName, level5Expr)))};
     while (std::optional<Expr> next{more.Parse(state)}) {
       result = std::move(next);
       result->source.ExtendToCover(source);


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D88001.293084.patch
Type: text/x-patch
Size: 670 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20200921/b1e48806/attachment.bin>


More information about the llvm-commits mailing list