[PATCH] D87828: [SCEV][NFC] Introduce isBasicBlockEntryGuardedByCond

[Max Kazantsev via Phabricator via llvm-commits]

mkazantsev added inline comments.


================
Comment at: llvm/lib/Analysis/ScalarEvolution.cpp:9455
+bool ScalarEvolution::isBasicBlockEntryGuardedByCond(const BasicBlock *BB,
+                                                     ICmpInst::Predicate Pred,
+                                                     const SCEV *LHS,
----------------
fhahn wrote:
> tab?
Eeek! It was supposed to be clang-formated... 


================
Comment at: llvm/lib/Analysis/ScalarEvolution.cpp:9518
 
   // Starting at the loop predecessor, climb up the predecessor chain, as long
   // as there are predecessors that can be found that have unique successors
----------------
fhahn wrote:
> I think it would be good to update the comment here, saying that we either start at the loop predecessor, if BB is the header of a loop or at the unique predecessor for other blocks.
Thanks for pointing out, I'll checkthe other comments here, too.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D87828/new/

https://reviews.llvm.org/D87828