[PATCH] D80367: [RISCV][MC] Print absolute targets of branch instructions

Fangrui Song via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sun Sep 20 10:33:02 PDT 2020


MaskRay accepted this revision.
MaskRay added a comment.
This revision is now accepted and ready to land.

This may require rebasing but the idea looks great to me.



================
Comment at: llvm/include/llvm/Target/Target.td:811
   string PrintMethod = "printOperand";
+  bit PrintRequiresAddr = 0;
   string EncoderMethod = "";
----------------
Consider moving it beside another `bit` field.


================
Comment at: llvm/utils/TableGen/CodeGenInstruction.h:89
 
+      /// PrinterMethodRequiresAddr - The method used to print operands of this
+      /// type requires the program address to print.
----------------
"Don’t duplicate function or class name at the beginning of the comment."

https://llvm.org/docs/CodingStandards.html#doxygen-use-in-documentation-comments


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D80367/new/

https://reviews.llvm.org/D80367



More information about the llvm-commits mailing list