[PATCH] D87971: [MemLoc] Support lllvm.memcpy.inline in MemoryLocation::getForArgument

Sun Sep 20 04:56:49 PDT 2020

fhahn accepted this revision.
fhahn added a comment.
This revision is now accepted and ready to land.

LGTM, thanks for also improving the test case!

================
Comment at: llvm/test/Transforms/DeadStoreElimination/MSSA/memintrinsics.ll:22
+define void @test2(i8* noalias %A, i8* noalias %B) {
 ; CHECK-LABEL: @test2(
+; CHECK-NEXT:    store i8 0, i8* [[A:%.*]], align 1
----------------
xbolva00 wrote:
> hmm, no aliasing pointers - shouldn't we remove this store?
Yes that looks like a missed optimization that was hidden by the fact that the store got removed because it was to an alloca that was never read! Thank you very much for improving the test so that it exposes this. Not sure what is going on, but it might be good to add a TODO/FIXME comment.

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D87971/new/

https://reviews.llvm.org/D87971