[PATCH] D87971: [MemLoc] Support lllvm.memcpy.inline in MemoryLocation::getForArgument

Sun Sep 20 03:51:12 PDT 2020

fhahn added inline comments.

================
Comment at: llvm/test/Transforms/DeadStoreElimination/MSSA/memintrinsics.ll:111
+
+  call void @llvm.memcpy.inline.p0i8.p0i8.i8(i8* %A, i8* %B, i8 -1, i1 false)
+
----------------
xbolva00 wrote:
> fhahn wrote:
> > why pass `-1` as length? That make the function be UB?
> > 
> >  It would probably also be better to just pass in 2 noalias pointers, rather than allocas. That way the memcpy call won't be removed?
> -1 is also used at line 18.
yeah, I don't think it really makes sense there either?

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D87971/new/

https://reviews.llvm.org/D87971