[PATCH] D87596: [Coroutines] Reuse storage for local variables with non-overlapping lifetimes

[Chuanqi Xu via Phabricator via llvm-commits]

ChuanqiXu added inline comments.


================
Comment at: llvm/lib/Passes/PassBuilder.cpp:881
   if (PTO.Coroutines)
-    MainCGPipeline.addPass(CoroSplitPass());
+    MainCGPipeline.addPass(CoroSplitPass(Level));
 
----------------
lxfind wrote:
> I don't quite understand how the pass registration works... Seems that here we are creating the CoroSplitPass with level passed in already. Why do we need to do it again in PassRegistry.def?
I think the code in `PassRegistry.def` is dealing with pass name parsing with opt tool. Maybe we need to invoke `coro-split` pass individually:
```
opt -coro-split ...
```


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D87596/new/

https://reviews.llvm.org/D87596