[PATCH] D87947: [AMDGPU] Make ds fp atomics overloadable
Stanislav Mekhanoshin via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Fri Sep 18 16:09:47 PDT 2020
rampitec marked an inline comment as done.
rampitec added inline comments.
================
Comment at: clang/lib/CodeGen/CGBuiltin.cpp:14772
+ llvm::Type *PTy = FTy->getParamType(0);
+ Src0 = Builder.CreatePointerBitCastOrAddrSpaceCast(Src0, PTy);
+ return Builder.CreateCall(F, { Src0, Src1, Src2, Src3, Src4 });
----------------
arsenm wrote:
> I don't think you need a cast here (at least an addrspacecast)
If removed builtins-amdgcn.cu fails. It is CUDA with LDS pointer passed as flat. I.e. it comes as cast from addrspace(3) to flat. Generic builtin handling below in this file does the same.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D87947/new/
https://reviews.llvm.org/D87947
More information about the llvm-commits
mailing list