[PATCH] D87961: [flang][msvc] Add explicit function template argument to applyFunction. NFC.

Michael Kruse via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Sep 18 23:35:14 PDT 2020


Meinersbur created this revision.
Meinersbur added reviewers: isuruf, DavidTruby, sscalpone, klausler, tskeith.
Meinersbur added a project: Flang.
Herald added a reviewer: jdoerfert.
Herald added a project: LLVM.
Herald added a subscriber: llvm-commits.
Meinersbur requested review of this revision.

Msvc has difficulties deducing the template argument here. The error message is:

  basic-parsers.h(790,12): error C2672: 'applyFunction': no matching overloaded function found

Explicitly pass the first template argument to help it.

This patch is part of the series to make flang compilable with MS Visual Studio http://lists.llvm.org/pipermail/flang-dev/2020-July/000448.html.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D87961

Files:
  flang/lib/Parser/basic-parsers.h


Index: flang/lib/Parser/basic-parsers.h
===================================================================
--- flang/lib/Parser/basic-parsers.h
+++ flang/lib/Parser/basic-parsers.h
@@ -787,7 +787,8 @@
   constexpr NonemptySeparated(const NonemptySeparated &) = default;
   constexpr NonemptySeparated(PA p, PB sep) : parser_{p}, separator_{sep} {}
   std::optional<resultType> Parse(ParseState &state) const {
-    return applyFunction(prepend<paType>, parser_, many(separator_ >> parser_))
+    return applyFunction<std::list<paType>>(
+        prepend<paType>, parser_, many(separator_ >> parser_))
         .Parse(state);
   }
 


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D87961.292947.patch
Type: text/x-patch
Size: 633 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20200919/bc3d818e/attachment.bin>


More information about the llvm-commits mailing list