[PATCH] D87951: Enable opt-bisect for the new pass manager

[Arthur Eubanks via Phabricator via llvm-commits]

aeubanks added a comment.

One of the issues raised in http://lists.llvm.org/pipermail/llvm-dev/2018-September/126477.html was that we'd have to somehow thread the `-opt-bisect-limit` through two different pass managers. If you look in `BackendUtil.cpp`'s `EmitAssemblyHelper::EmitAssemblyWithNewPassManager()`, there's a NPM for the optimization pipeline, then a legacy PM for the codegen pipeline. `OptBisect.rst` says that you can use `-opt-bisect-limit` through `clang -mllvm -opt-bisect-limit=`, and I don't think that would properly work with this implementation since the codegen pipeline would restart `-opt-bisect-limit`.

I guess there aren't any tests for that though, since all references to `-opt-bisect-limit` are in `llvm/test` and use `opt`/`llc`.



================
Comment at: llvm/lib/Passes/StandardInstrumentations.cpp:340-342
+  if (any_isa<const Region *>(IR)) {
+    return "region";
+  }
----------------
I don't think the NPM has a concept of a Region pass, so this shouldn't be necessary.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D87951/new/

https://reviews.llvm.org/D87951