[PATCH] D86955: [Hexagon] Make HexagonVLCR compatibile with New PM

[Ankit via Phabricator via llvm-commits]

quic_aankit added a comment.

In D86955#2283186 <https://reviews.llvm.org/D86955#2283186>, @pzheng wrote:

> In D86955#2280318 <https://reviews.llvm.org/D86955#2280318>, @quic_aankit wrote:
>
>> In D86955#2274924 <https://reviews.llvm.org/D86955#2274924>, @pzheng wrote:
>>
>>> In D86955#2271328 <https://reviews.llvm.org/D86955#2271328>, @quic_aankit wrote:
>>>
>>>> In D86955#2261551 <https://reviews.llvm.org/D86955#2261551>, @pzheng wrote:
>>>>
>>>>> In D86955#2261510 <https://reviews.llvm.org/D86955#2261510>, @quic_aankit wrote:
>>>>>
>>>>>> In D86955#2261498 <https://reviews.llvm.org/D86955#2261498>, @pzheng wrote:
>>>>>>
>>>>>>> Is there any existing test case for this pass with the legacy pass manager? If so, you might want to add one with the new pass manager too.
>>>>>>
>>>>>> All the existing testcases use opt to run the pass. The pass is not run integrated in the main list of passes for any -Ox level.
>>>>>
>>>>> That's what I meant. For each legacy pass manager test "RUN: opt -hexagon-vlcr ...", you can add a corresponding new pass manager test "RUN: opt -passes=hexagon-vlcr". This way, we will have the same test coverage with both the legacy and new pass managers.
>>>>
>>>> Hi pzheng, I could not figure out a way to register a target specific pass in opt? I can see that llvm/lib/Passes/PassRegistry.def is the registry for target independent passes. Can you point me to an example/API which can help me in registering this pass so that I can use it -passes option in opt?
>>>
>>> I am not sure if there is a better place to register the pass other than PassRegistry.def. Maybe someone who knows can comment on this.
>>
>> Hi pzheng, testing target specific passes using opt+NPM is not currently supported and the work is still work-in-progress. Can we land this without modifying the testcases for now?
>
> Hi @quic_aankit, just to be clear, you tried registering the pass in PassRegistry.def, but still couldn't get "opt -passes=hexagon-vlcr" to work, right? If so, I am fine with leaving out the tests for now, but we should probably mention in the commit message that tests are still to be ported.

Yes @pzheng . I cannot register the pass the in PassRegisry.def as I cannot include the requried header file from lib/target/hexagon. The LLVM community confirmed that testing target specific passes using opt is a work in progress and not supported yet.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D86955/new/

https://reviews.llvm.org/D86955