[PATCH] D87798: [NewPM][CGSCC] Handle newly added functions in updateCGAndAnalysisManagerForPass

[Alina Sbirlea via Phabricator via llvm-commits]

asbirlea added a comment.

The general comment (I mentioned this offline too), is that this is much closer to the direction I'd see the changes going. By this, I mean, the APIs removed here seemed unnecessary, and inlining their functionality at the callsite made more sense. 
This seems the right approach for coroutines and outlining. I'm not clear for inlining at this point, Im working to understand the flow better there.



================
Comment at: llvm/lib/Analysis/CGSCCPassManager.cpp:518
 
+  for (Node *NewNode : NewNodes) {
+    G.initNode(*NewNode, *C);
----------------
Remove braces.


================
Comment at: llvm/lib/Analysis/CGSCCPassManager.cpp:519
+  for (Node *NewNode : NewNodes) {
+    G.initNode(*NewNode, *C);
+  }
----------------
I'm not clear how adding this call impacts the Inliner.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D87798/new/

https://reviews.llvm.org/D87798