[PATCH] D87913: [SVE][CodeGen] Lower legal integer -> floating point conversions

[Eli Friedman via Phabricator via llvm-commits]

efriedma accepted this revision.
efriedma added a comment.
This revision is now accepted and ready to land.

LGTM with one minor comment.



================
Comment at: llvm/lib/Target/AArch64/AArch64ISelLowering.h:108
+  UCVTF_MERGE_PASSTHRU,
+  SCVTF_MERGE_PASSTHRU,
   FCVTZU_MERGE_PASSTHRU,
----------------
Might as well name these SINT_TO_FP_MERGE_PASSTHRU  and UINT_TO_FP_MERGE_PASSTHRU.  I know we had a long discussion about the names on the other patch, but this direction doesn't suffer from that problem.  The intrinsic has exactly the same semantics as the SelectionDAG node.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D87913/new/

https://reviews.llvm.org/D87913