[PATCH] D86977: [IRSim][IROutliner] Limit to extracting regions that only require inputs
Jessica Paquette via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Fri Sep 18 11:11:54 PDT 2020
paquette added inline comments.
================
Comment at: llvm/lib/Transforms/IPO/IROutliner.cpp:510
+ findAddInputsOutputs(M, *OS);
+ if (!OS->IgnoreRegion)
+ OutlinedRegions.push_back(OS);
----------------
If `findAddInputsOutputs` returned a bool, you could just do
```
if (findAddInputsOutputs(M, *OS) {
// Found the outputs and inputs. We can outline this.
OutlinedRegions.push_back(OS);
continue;
}
// Couldn't find the outputs/inputs. Bail out.
OS->reattachCandidate();
```
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D86977/new/
https://reviews.llvm.org/D86977
More information about the llvm-commits
mailing list