[PATCH] D86977: [IRSim][IROutliner] Limit to extracting regions that only require inputs

[Jessica Paquette via Phabricator via llvm-commits]

paquette added inline comments.


================
Comment at: llvm/lib/Transforms/IPO/IROutliner.cpp:491
+    // each section in the set.
+    NotSame.clear();
+    CurrentGroup.findSameConstants(NotSame);
----------------
jroelofs wrote:
> Is there a performance issue with declaring `NotSame` here? Sinking declarations helps show the reader that there are no loop-carried dependencies.
I think this is a leftover from this: https://llvm.org/docs/ProgrammersManual.html#vector

But I'm not sure if this applies to DenseSet.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D86977/new/

https://reviews.llvm.org/D86977