[PATCH] D87903: [CSInfo][GlobalISel] CallSiteInfo support when using GlobalISel

Matt Arsenault via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Sep 18 10:29:34 PDT 2020


arsenm added inline comments.


================
Comment at: llvm/lib/CodeGen/GlobalISel/IRTranslator.cpp:2203
+    unsigned MINo = 0, ArgNo = 0;
+    for (const MachineInstr &MI : MIRBuilder.getMBB()) {
+      // The only relevant instructions are the ones that were added to
----------------
This is making a *lot* of assumptions about what lowerCall did. You can't assume there will only be a single copy exactly corresponding to a single IR argument, that appear in order


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D87903/new/

https://reviews.llvm.org/D87903



More information about the llvm-commits mailing list