[PATCH] D87824: [lld][ELF][test] Add additional LTO testing

Fangrui Song via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Sep 18 09:58:58 PDT 2020


MaskRay accepted this revision.
MaskRay added a comment.

LGTM.



================
Comment at: lld/test/ELF/lto/internalize-basic.ll:14
+
+define hidden void @bar() {
   ret void
----------------
jhenderson wrote:
> MaskRay wrote:
> > You can enhance the test by deleting `hidden`. The important property is `isUsedInRegularObj`, not visibility.
> Done, but I noticed that `foo` is also `hidden`. Any idea why?
I think that is fine. It adds some variants to further demonstrate the property after the main property has been tested.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D87824/new/

https://reviews.llvm.org/D87824



More information about the llvm-commits mailing list