[PATCH] D87381: [LLD][PowerPC][test] Update thunk range error report for PPC64PCRelLongBranchThunk

Victor Huang via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Sep 18 07:42:02 PDT 2020


NeHuang marked 3 inline comments as done.
NeHuang added inline comments.


================
Comment at: lld/test/ELF/ppc64-pcrel-call-to-toc-error.s:26
+  .Lfunc_gep1:
+  addis 2, 12, .TOC.-.Lfunc_gep1 at ha
+  addi 2, 2, .TOC.-.Lfunc_gep1 at l
----------------
MaskRay wrote:
> Consider deleting unneeded setup instructions
I could remove them but it would be better to keep them because the asm doesn't really make sense for a toc-based callee without the toc setup. Of course, I can remove them if you insist. 


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D87381/new/

https://reviews.llvm.org/D87381



More information about the llvm-commits mailing list