[PATCH] D85626: [tools][remarks-shlib] Don't build libRemarks.so without PIC
Roman Lebedev via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Fri Sep 18 07:14:55 PDT 2020
lebedev.ri added inline comments.
================
Comment at: llvm/tools/remarks-shlib/CMakeLists.txt:1-2
-set(LLVM_LINK_COMPONENTS
- Remarks
- )
+# Building shared libraries requires PIC objects.
+if(LLVM_ENABLE_PIC)
+
----------------
Is this the only LLVM shared library that was missing this `if(LLVM_ENABLE_PIC)` check?
If not, this comment is misleading, since clearly it worked so far everywhere else.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D85626/new/
https://reviews.llvm.org/D85626
More information about the llvm-commits
mailing list