[PATCH] D87902: [GlobalISel] Fix enumeration of entry basic blocks when using GlobalISel

[Matt Arsenault via Phabricator via llvm-commits]

arsenm added a comment.

Why is a new entry block added in the first place?



================
Comment at: llvm/test/CodeGen/X86/rename-new-entry.ll:3
+;; GlobalISel
+; RUN: llc -global-isel %s -stop-after=finalize-isel -o %t.mir
+; RUN: cat %t.mir | FileCheck %s
----------------
stop-after=irtranslator. This also doesn't need to use a temporary file and should directly pipe to FIleCheck


================
Comment at: llvm/test/CodeGen/X86/rename-new-entry.ll:12-15
+; ModuleID = 'test/CodeGen/X86/rename-new-entry.c'
+source_filename = "test/CodeGen/X86/rename-new-entry.c"
+target datalayout = "e-m:e-i64:64-f80:128-n8:16:32:64-S128"
+target triple = "x86_64-unknown-linux-gnu"
----------------
Remove these and move triple to llc argument list


================
Comment at: llvm/test/CodeGen/X86/rename-new-entry.ll:24
+
+; Function Attrs: noinline nounwind uwtable
+define dso_local i32 @fn3(i32 %a, i32 %b, i32 %c) local_unnamed_addr {
----------------
Remove these comments


================
Comment at: llvm/test/CodeGen/X86/rename-new-entry.ll:45-49
+!llvm.module.flags = !{!0}
+!llvm.ident = !{!1}
+
+!0 = !{i32 1, !"wchar_size", i32 4}
+!1 = !{!"clang version 9.0.0"}
----------------
Don't need this metadata


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D87902/new/

https://reviews.llvm.org/D87902