[PATCH] D87866: IR: Move denormal mode parsing from MachineFunction to Function
Matt Arsenault via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Fri Sep 18 06:16:24 PDT 2020
arsenm added inline comments.
================
Comment at: llvm/lib/CodeGen/MachineFunction.cpp:277
// TODO: Should probably avoid the connection to the IR and store directly
// in the MachineFunction.
+ return F.getDenormalMode(FPType);
----------------
jdoerfert wrote:
> Is the TODO still accurate? We seem to go in the opposite direction.
Well I think it should be cached somewhere rather than string parsing every time you want to query this (this will just happen more frequently in codegen)
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D87866/new/
https://reviews.llvm.org/D87866
More information about the llvm-commits
mailing list