[PATCH] D87855: [llvm-install-name-tool] Validate -id value early

James Henderson via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Sep 18 01:04:29 PDT 2020


jhenderson accepted this revision.
jhenderson added a comment.

I guess if you wanted to add explicit testing that the behaviour happens regardless of the presence of specific load commands, that would be possible, using a minimal Mach-O file, but I don't mind if you don't want to. LGTM, if you don't.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D87855/new/

https://reviews.llvm.org/D87855



More information about the llvm-commits mailing list