[PATCH] D86360: Add new hidden option -print-changed which only reports changes to IR

[Yuanfang Chen via Phabricator via llvm-commits]

ychen added a comment.

In D86360#2279738 <https://reviews.llvm.org/D86360#2279738>, @jamieschmeiser wrote:

> Respond to build/test problems:  Remove extra ;, remove call to base dtor,
> change tests to have regex for PassID and ModuleID

The regex checking is not sufficient. Could you please check the common sub-string of GCC's and MSVC's output?



================
Comment at: llvm/lib/IR/LegacyPassManager.cpp:89
                      cl::desc("When printing IR for print-[before|after]{-all} "
-                              "always print a module IR"),
+                              "and change reporters always print a module IR"),
                      cl::init(false), cl::Hidden);
----------------
Add a comma before "always"


================
Comment at: llvm/test/Other/change-printer.ll:6
+; Simple functionality check.
+; RUN: opt -S -print-changed -passes=instsimplify 2>&1 -o /dev/null < %s | FileCheck %s --check-prefix=CHECK_SIMPLE
+;
----------------
For check prefixes, using dash is much more common than underscore.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D86360/new/

https://reviews.llvm.org/D86360