[PATCH] D86360: Add new hidden option -print-changed which only reports changes to IR

[Fangrui Song via Phabricator via llvm-commits]

MaskRay added inline comments.


================
Comment at: llvm/test/Other/change-printer.ll:57
+; CHECK0: *** IR Pass PassManager<llvm::Function> (function: f) ignored ***
+; CHECK0: *** IR Pass ModuleToFunctionPassAdaptor<llvm::PassManager<llvm::Function> > (module) ignored ***
+; CHECK0: *** IR Dump After VerifierPass (module) omitted because no change ***
----------------
jamieschmeiser wrote:
> jamieschmeiser wrote:
> > rupprecht wrote:
> > > I'm seeing test failures that this should actually be: `ModuleToFunctionPassAdaptor<llvm::PassManager<llvm::Function>>` (note the lack of whitespace at the end in `>>`).
> > > 
> > > Is it safe to change it to that, or is this test somehow sensitive to the build/runtime environment? `> >` being required is a legacy of older versions of C++.
> > @rupprecht I see this and can fix this by removing the tail part of the CHECK.  There are probably others that need the same fix and I will do this fix right away.  Thanks for pointing this out.
> Actually, the better fix is to just use a reg-ex to make the space optional, which I will do.
> 
The current tested form is too loose. Worth adding some `CHECK-NEXT:` with the first line of the dump, e.g. `CHECK-NEXT: define i32 @g()`


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D86360/new/

https://reviews.llvm.org/D86360