[PATCH] D87870: [GISel] Add new combines for G_FMUL

Matt Arsenault via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Sep 17 16:22:53 PDT 2020


arsenm added inline comments.


================
Comment at: llvm/include/llvm/CodeGen/GlobalISel/CombinerHelper.h:358-359
 
+  /// Transform G_FMUL(x, -1) to G_FNEG(x)
+  bool applyCombineFMulByNegativeOne(MachineInstr &MI);
+
----------------
This is incorrect since it replaces a canonicalizing operation with a non-canonicalizing operation


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D87870/new/

https://reviews.llvm.org/D87870



More information about the llvm-commits mailing list