[PATCH] D87864: AMDGPU: Check global FP atomics match default FP mode
Stanislav Mekhanoshin via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Thu Sep 17 15:48:35 PDT 2020
rampitec added inline comments.
================
Comment at: llvm/lib/Target/AMDGPU/SIISelLowering.cpp:11807
if (AS == AMDGPUAS::GLOBAL_ADDRESS && Subtarget->hasAtomicFaddInsts()) {
+ if (!fpModeMatchesGlobalFPAtomicMode(RMW))
+ return AtomicExpansionKind::CmpXChg;
----------------
Does it depend on the address space? What about LDS atomics, don't you need to move this out of the if statement?
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D87864/new/
https://reviews.llvm.org/D87864
More information about the llvm-commits
mailing list