[PATCH] D87381: [LLD][PowerPC][test] Update thunk range error report for PPC64PCRelLongBranchThunk

Fangrui Song via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Sep 17 14:56:48 PDT 2020


MaskRay added inline comments.


================
Comment at: lld/test/ELF/ppc64-pcrel-call-to-toc-error.s:1
+# REQUIRES: ppc, system-linux
+# RUN: echo 'SECTIONS { \
----------------
Delete system-linux

I think this test is portable and runs on other systems.


================
Comment at: lld/test/ELF/ppc64-pcrel-call-to-toc-error.s:26
+  .Lfunc_gep1:
+  addis 2, 12, .TOC.-.Lfunc_gep1 at ha
+  addi 2, 2, .TOC.-.Lfunc_gep1 at l
----------------
Consider deleting unneeded setup instructions


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D87381/new/

https://reviews.llvm.org/D87381



More information about the llvm-commits mailing list