[PATCH] D86906: [AArch64LdStOptimzation] fix a bug in AArch64 Load Store Optimization

Thu Sep 17 10:20:51 PDT 2020

fhahn added inline comments.

================
Comment at: llvm/test/CodeGen/AArch64/aarch64-ldst-subsuperReg-no-ldp.mir:12
+#
+# CHECK-NOT: LDP
+---
----------------
congzhe wrote:
> congzhe wrote:
> > fhahn wrote:
> > > Given that the test is very short now, could you check for the full instruction sequence (LDR, LDR, RET)? Just to make sure the loads are not dropped completely (as `$w10` is not really used any more)/.
> > > 
> > > Also, it might eb good to add another test with the order of `LDRSW/LDRW` flipped.
> > @fhahn Thanks, now checking the full instruction sequence; 
> > 
> > Also added another test with the order of LDRSW/LDRW flipped.
> Also made similar updates in the other patch
> https://reviews.llvm.org/D86956
> 
Thanks, that looks good!

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D86906/new/

https://reviews.llvm.org/D86906