[PATCH] D87821: [AMDGPU] Set DS alignment requirements to be more strict

[Matt Arsenault via Phabricator via llvm-commits]

arsenm added inline comments.


================
Comment at: llvm/lib/Target/AMDGPU/SIISelLowering.cpp:1439
       if (IsFast)
         *IsFast = true;
       return true;
----------------
Can you add a fixme to not report fast for 2 byte alignment?


================
Comment at: llvm/test/CodeGen/AMDGPU/GlobalISel/lds-misaligned-bug.ll:4
 ; RUN: llc -global-isel -march=amdgcn -mcpu=gfx1012 -verify-machineinstrs < %s | FileCheck -check-prefixes=GCN,SPLIT %s
 ; RUN: llc -global-isel -march=amdgcn -mcpu=gfx1010 -verify-machineinstrs -mattr=+cumode < %s | FileCheck -check-prefixes=GCN,VECT %s
 
----------------
This should also probably have some checks with unaligned access enabled


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D87821/new/

https://reviews.llvm.org/D87821