[PATCH] D87746: [mlir] Fix of updating function signature in normalizing memrefs

[Haruki Imai via Phabricator via llvm-commits]

imaihal added inline comments.


================
Comment at: mlir/test/lib/Dialect/Test/TestOps.td:635
+  let description = [{
+    The "test.op_entrypoint" function indicates the main entry point.
+  }];
----------------
bondhugula wrote:
> It's still not clear what this means. Did you mean to say it's an arbitrary op with a reference to a function symbol? Why is even an entry point in the context here?
A op for entry point issued the error in my actual use case. So, I created the test op for entry point, but as you said, we should make it more general. 

`OPEntryPoint` -> `OPFuncRef`
`op_entrypoint` -> `op_funcref`
`The "test.op_entrypoint" function indicates the main entry point.`
-> `The "test.op_funcref" function has a reference to a function symbol`
How about this? 


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D87746/new/

https://reviews.llvm.org/D87746