[PATCH] D87232: [SVE][CodeGen] Lower floating point -> integer conversions

[Kerry McLaughlin via Phabricator via llvm-commits]

kmclaughlin added inline comments.


================
Comment at: llvm/test/CodeGen/AArch64/sve-fcvt.ll:126
+
+define <vscale x 2 x i16> @fcvtzu_h_nxv2f16(<vscale x 2 x half> %a) {
+; CHECK-LABEL: fcvtzu_h_nxv2f16:
----------------
paulwalker-arm wrote:
> I know it's in the langref but it cannot hurt to add a comment here along the lines of `NOTE: Using fcvtzs is safe because fptoui overflow is considered poison and a 64bit signed value encompasses the entire range of a 16bit unsigned value. ` What do you think?
I've added your comment in here, it will definitely help me to remember why this is safe in future :)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D87232/new/

https://reviews.llvm.org/D87232