[PATCH] D87824: [lld][ELF][test] Add additional LTO testing

James Henderson via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Sep 17 05:54:19 PDT 2020


jhenderson added inline comments.


================
Comment at: lld/test/ELF/lto/undef-mixed2.s:5
+# RUN: llvm-mc %s -o %t.o -filetype=obj -triple=x86_64-pc-linux
+# RUN: llvm-as %p/Inputs/undef-mixed2.ll -o %t2.o
+# RUN: ld.lld %t2.o %t.o -o %t.so -shared
----------------
grimar wrote:
> Any reason not to use `split-file` instead of adding a new input?
That's what happens when you try to write/copy tests whilst half asleep. Mostly, it was becuase this test was derived from undef-mixed.s originally. I'm happy to use `split-file` though.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D87824/new/

https://reviews.llvm.org/D87824



More information about the llvm-commits mailing list