[PATCH] D86522: [RISC-V] Implement RISCVInstrInfo::isCopyInstrImpl()

Thu Sep 17 04:59:14 PDT 2020

jrtc27 added a comment.

In D86522#2278718 <https://reviews.llvm.org/D86522#2278718>, @arichardson wrote:

> In D86522#2278710 <https://reviews.llvm.org/D86522#2278710>, @luismarques wrote:
>
>> I was hoping others would chime in regarding what instructions should be handled in this hook.
>>
>> @arichardson How do you feel about removing the ORI/XORI and landing this patch? (I also have no major objections to just landing as is). We can always further improve it later. Ideally this would add tests, but if that's not easy I think it's OK to land it as is.
>
> Sure, will do that.

Yeah I agree without further info I think we should land just the canonical moves.

================
Comment at: llvm/lib/Target/RISCV/RISCVInstrInfo.cpp:548
+  case RISCV::FSGNJ_S:
+    // The canonical floatig-point move is fsgnj rd, rs, rs.
+    if (MI.getOperand(1).isReg() && MI.getOperand(2).isReg() &&
----------------

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D86522/new/

https://reviews.llvm.org/D86522