[PATCH] D87763: [llvm-readelf/obj][test] - Document what we print in various places for unnamed section symbols.

[George Rimar via Phabricator via llvm-commits]

grimar added inline comments.


================
Comment at: llvm/test/tools/llvm-readobj/ELF/dyn-symbols.test:327
+    Type:    [[TYPE=STT_NOTYPE]]
+    StName:  [[NAME=<none>]]
+    Index:   [[INDEX=<none>]]
----------------
jhenderson wrote:
> I think it would be slightly more obvious to use `Name: [[NAME=bar]]` and then just set `-DNAME=''`, if that's possible?
Interesting idea. Done.


================
Comment at: llvm/test/tools/llvm-readobj/ELF/mips-got.test:707-708
+    Section: .got
+  - Type:    STT_SECTION
+    Index:   SHN_COMMON
----------------
jhenderson wrote:
> Is there any particular reason you've chosen to have both absolute and common here, but none of the other varieties?
No. I've just showed 2 arbitrary symbols revealing the issue and an arbitrary normal symbol in between of them.
I do not feel it worth to check all possible values here? They are tested in `symbol-shndx.test`, we just have the same issue in all other places because of using the same API for getting a symbol name.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D87763/new/

https://reviews.llvm.org/D87763