[PATCH] D68620: DebugInfo: Use base address selection entries for debug_loc

[Orlando Cazalet-Hyams via Phabricator via llvm-commits]

Orlando added a comment.

> Ah, OK - so it sounds like we're back down below the size before I added debug_loc base address specifiers? That's good to hear!

Yeah looks like it.

> If you're really interested in binary size, then, it might be worth an extra experiment to see what would happen if you disable base address specifiers - might still get you significantly below where we were before (now that the "don't use debug_loc so often" improvements have been made) - so there might still be some discussion about whether more selective use of base address selection entries would be good for you/others.

SGTM I will have a look. To disable base address specifiers here is it enough to just pass in false for ShouldUseBaseAddress to emitRangeList on line DwarfDebug.cpp:2398?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D68620/new/

https://reviews.llvm.org/D68620