[PATCH] D87763: [llvm-readelf/obj][test] - Document what we print in various places for unnamed section symbols.

[James Henderson via Phabricator via llvm-commits]

jhenderson added inline comments.


================
Comment at: llvm/test/tools/llvm-readobj/ELF/dyn-symbols.test:327
+    Type:    [[TYPE=STT_NOTYPE]]
+    StName:  [[NAME=<none>]]
+    Index:   [[INDEX=<none>]]
----------------
I think it would be slightly more obvious to use `Name: [[NAME=bar]]` and then just set `-DNAME=''`, if that's possible?


================
Comment at: llvm/test/tools/llvm-readobj/ELF/dyn-symbols.test:352
+
+# VERSIONED-SEC-SYM-GNU:    Num: {{.*}} Ndx Name
+# VERSIONED-SEC-SYM-GNU:      1: {{.*}} UND foo
----------------
If you add the check for the first line of GNU output that says how many symbols there are, I think you can probably get away with simplifying the above patterns to single line checks for the names (i.e. without the need for -SAME).


================
Comment at: llvm/test/tools/llvm-readobj/ELF/hash-symbols.test:87
+    Type:    [[TYPE=STT_NOTYPE]]
+    StName:  [[NAME=<none>]]
   - Name:    aaa
----------------
Same comment as above.


================
Comment at: llvm/test/tools/llvm-readobj/ELF/mips-got.test:707-708
+    Section: .got
+  - Type:    STT_SECTION
+    Index:   SHN_COMMON
----------------
Is there any particular reason you've chosen to have both absolute and common here, but none of the other varieties?


================
Comment at: llvm/test/tools/llvm-readobj/ELF/symbol-shndx.test:63
+    Type:    [[TYPE=STT_NOTYPE]]
+    StName:  [[NAME=<none>]]
   - Name:    normal
----------------
Same comment as above re. naming.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D87763/new/

https://reviews.llvm.org/D87763