[PATCH] D87740: [llvm-profdata]Fix llvm-profdata crash on compact binary profile

[Lei Wang via Phabricator via llvm-commits]

wlei added a comment.

In D87740#2278197 <https://reviews.llvm.org/D87740#2278197>, @wenlei wrote:

> LGTM. A small nit: the code snippet in the description could be removed as it's indeed in the codebase already. :)

Yes, thanks for the suggestion



================
Comment at: llvm/test/tools/llvm-profdata/compact-sample.proftext:3
 
-# RUN: llvm-profdata show -sample %S/Inputs/compat-sample.profdata  | FileCheck %s 
+# RUN: llvm-profdata show -sample %S/Inputs/compat-sample.profdata  | FileCheck %s
 
----------------
MaskRay wrote:
> `  |` -> ` |`
Fixed, thanks for your feedback!


================
Comment at: llvm/test/tools/llvm-profdata/compact-sample.proftext:10
+
+# RUN: llvm-profdata show -hot-func-list -sample %S/Inputs/compat-sample.profdata  | FileCheck %s -check-prefix=HOTFUNC
+# HOTFUNC: 24753993 out of 24754010 profile counts (100.00%) are from hot functions.
----------------
MaskRay wrote:
> `  |` -> ` |`
> 
> (Nit: for FileCheck options, the two-dash `--check-prefix` is preferred.)
Fixed, thanks for your feedback!


================
Comment at: llvm/test/tools/llvm-profdata/compact-sample.proftext:18
+
+# OVERLAP: Program level:
+# OVERLAP-NEXT:   Whole program profile similarity: 100.000%
----------------
MaskRay wrote:
> Indent this line so that the indentation difference with the next line matches the actual output.
Fixed, thanks for your feedback!


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D87740/new/

https://reviews.llvm.org/D87740