[PATCH] D87712: [mlir][openacc] Change operand type from index to AnyInteger in parallel op

[Valentin Clement via Phabricator via llvm-commits]

clementval added inline comments.


================
Comment at: mlir/include/mlir/Dialect/OpenACC/OpenACCOps.td:84
 
-  let arguments = (ins Optional<Index>:$async,
-                       Variadic<Index>:$waitOperands,
-                       Optional<Index>:$numGangs,
-                       Optional<Index>:$numWorkers,
-                       Optional<Index>:$vectorLength,
+  let arguments = (ins Optional<AnyInteger>:$async,
+                       Variadic<AnyInteger>:$waitOperands,
----------------
clementval wrote:
> ftynse wrote:
> > Make sure `index` is also supported. It was intended as a platform-specific opaque size type. While it's reasonable to adhere to the spec and allow any integer, most lowerings coming from higher levels and many standard ops (e.g. taking the size of some container) will use `index`.
> I update this to use `AnyTypeOf<[AnyInteger, Index]>`
If that's fine I'll make a  follow up patch to use the same type in `acc.loop`


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D87712/new/

https://reviews.llvm.org/D87712